Fix parsing of CWalletTx::mapSaplingNoteData
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d492338. This crate specifically parses zcashd wallets using `zcash_primitives 0.19` and its dependencies; introducing a second version of the `incrementalmerkletree` crates breaks compatibility with the `zcash_primitives` version.
In `zcashd`, `mapSaplingNoteData` is always parsed if the transaction version supports sapling; the implementation in `wallet_tx` parsing incorrectly parsed it instead as a value wrapped in `std::optional`. This causes an off-by-one error in the remainder of `CWalletTx` parsing, but that error only appears sometimes because the `0x00` and `0x01` discriminants for optional values are also valid vector lengths, so transactions that did not include a Sapling component would not have a parse error here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.